Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint and prettier #113

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

sergeichestakov
Copy link
Contributor

@sergeichestakov sergeichestakov commented Aug 21, 2023

Why

We should definitely have eslint and prettier set up in this repo, esp now that Szymon and others are collaborating here more often, so that our formatting is consistent. I've been meaning to set this up just haven't gotten around to it until now.

Fixes WS-824

What changed

  • Add eslint config which is as close as possible to our web config (minus custom rules, a11y/storybook other plugins we don't support, etc).
  • Add prettier config which matches our web config (single quote strings, trailing comma, etc).
  • Run lint fix on every file under src

Test plan

  • CI / lint passes (run pnpm run lint locally)
  • Config looks good
  • App still works/starts/builds

@linear
Copy link

linear bot commented Aug 21, 2023

@sergeichestakov sergeichestakov merged commit 7afdb2f into main Aug 22, 2023
@sergeichestakov sergeichestakov deleted the @sergeichestakov/add-eslint-config branch August 22, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants